Example in the github repository examples-master is wrong (Win 10 X64)

Hi everyone,

I found some bugs in the repository examples-master:

  1. download examples-master into C:\dev\ros2

  2. open developer cmd prompt for 2015

  3. go to C:\dev\ros2

  4. call local_setup.bat

  5. go to C:\dev\ros2\examples-master\rclcpp\minimal_publisher\

  6. mkdir src

  7. move all files into C:\dev\ros2\examples-master\rclcpp\minimal_publisher\src\

  8. ament build
    9: error_info:
    “C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp_minimal_publisher\examples_rclcpp_mi
    nimal_publisher.sln” (default target) (1) ->
    “C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp_minimal_publisher\publisher_not_comp
    osable.vcxproj.metaproj” (default target) (5) ->
    “C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp_minimal_publisher\publisher_not_comp
    osable.vcxproj” (default target) (7) ->
    (ClCompile target) ->
    C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\src\not_composable.cpp(37): error C2039: ‘get_logger’: is
    not a member of ‘rclcpp::node::Node’ [C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcp
    p_minimal_publisher\publisher_not_composable.vcxproj]

    "C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp_minimal_publisher\examples_rclcpp_mi
    nimal_publisher.sln" (default target) (1) ->
    "C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp_minimal_publisher\publisher_member_f
    unction.vcxproj.metaproj" (default target) (4) ->
    "C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp_minimal_publisher\publisher_member_f
    unction.vcxproj" (default target) (8) ->
      C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\src\member_function.cpp(39): error C2039: 'get_logger': i
    s not a member of 'MinimalPublisher' [C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp
    _minimal_publisher\publisher_member_function.vcxproj]
    
    
    "C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp_minimal_publisher\examples_rclcpp_mi
    nimal_publisher.sln" (default target) (1) ->
    "C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp_minimal_publisher\publisher_lambda.v
    cxproj.metaproj" (default target) (3) ->
    "C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp_minimal_publisher\publisher_lambda.v
    cxproj" (default target) (9) ->
      C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\src\lambda.cpp(35): error C2039: 'get_logger': is not a m
    ember of 'MinimalPublisher' [C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp_minimal_
    publisher\publisher_lambda.vcxproj]
      C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\src\lambda.cpp(35): error C2039: '__this': is not a membe
    r of 'MinimalPublisher' [C:\dev\ros2\examples-ardent\rclcpp\minimal_publisher\build\examples_rclcpp_minimal_publ
    isher\publisher_lambda.vcxproj]
    

    3 Warning(s)
    4 Error(s)

Please do not double post your question. You already asked it in a different thread (ROS2 application development in visual studio 2017 or 2015 (win 10 x64)).

In general: please also do not post images of your problem. The rational is that the textual content in your screen shot is not searchable and therefore not findable by others.