Issues about Migration Guide

Next Generation ROS
1

Hi everyone,

I tested the example from the Migration Guide in my PC(win 10 x64, binary packages installation) and found some issues.

cmake_minimum_required(VERSION 2.8.3) --> cmake_minimum_required(VERSION 3.5)
auto node = rclcpp::node::Node::make_shared(“talker”); --> auto node = rclcpp::Node::make_shared(“talker”);
rclcpp::rate::Rate loop_rate(10); --> rclcpp::Rate loop_rate(10);

2

BTW, I’m not sure that rclcpp::Rate spins while it sleeps. It hasn’t in times gone by. Generally, you will break things in ROS2 if you sleep instead of spin; your buffers will overflow, etc. We usually use the timeouts on the spin methods instead.

3

The migration guide is a wiki page. Please feel free to edit it and improve it where you see fit. It would be good to post a link to the diff here afterwards to make others aware of your change. Thanks.