Looking for feedback on a ROS C++ & python init/shutdown wrapper

Peter_Mitrano · 2021-02-25T19:35:12.288Z

Hey folks, I was hoping to get some feedback from others on a new bit of code I’ve written:

UM-ARM-Lab/arc_utilities/blob/master/src/arc_utilities/ros_init.py

import traceback
from types import TracebackType
from typing import Callable

import roscpp_initializer

import rospy


def rospy_and_cpp_init(name):
    """
    Use this function any time you want to call into C++ ROS code.
    The C++ node will be named "cpp_" + name
    You can use this in place of the moveit roscpp_initializer

    Args:
        name: the name of the python node, and the C++ node will be named "cpp_" + name

    Returns:

This file has been truncated. show original

github.com

UM-ARM-Lab/arc_utilities/blob/master/src/roscpp_initializer.cpp

#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
#include <pybind11/stl_bind.h>
#include <ros/console.h>
#include <ros/ros.h>
#include <ros/spinner.h>

#include <algorithm>
#include <memory>
#include <string>
#include <vector>

namespace py = pybind11;

std::unique_ptr<ros::AsyncSpinner> spinner;

void init_node(std::string const &name, std::vector<std::string> argv = {}, int const rospy_log_level = 2,
               bool anonymous = false, bool disable_rosout = false, bool disable_signals = false) {
  switch (rospy_log_level) {
    case 0:

This file has been truncated. show original

The goal is to have clean and consistent startup & shutdown behavior for python nodes. The catch is that I want this to work when I am using bindings to C++ ROS code. Therefore, I need the C++ ros::initialize to be called, hence the little roscpp_initializer you see here.

Do you think using a context manager is a good idea here? Do you have something similar to this in your code base? Thoughts on when this might fail/be a bad idea?

Thanks!

rgov · 2021-02-25T20:07:01.611Z

If the only use of RosContext is going to be through the with_ros function decorator, then why not simply make the decorator do:

def wrapper(*args, **kwargs):
    rospy_and_cpp_init(name)
    try:
        func(*args, **kwargs)
    finally:
        shutdown()

Otherwise if there’s another use for RosContext, a more descriptive name like RosNode might be more readable:

with RosNode("talker"):
    rospy.Publisher(...)

Is it possible to have multiple RosContexts executing in parallel, for instance in an asyncio or threaded program? If so, how does rospy.Publisher know which to associate with?

What about just having rospy_and_cpp_init use atexit.register() to shutdown the node cleanly when the program terminates?