sloretz
December 28, 2022, 1:10am
1
Hello Noetic maintainers!
Starting now, I will be holding new Noetic ros/rosdistro release PRs with a plan to sync ROS Noetic packages to the main apt repo on 2022-12-29. Please comment here if there are any issues I should know about before performing the sync.
There are currently 118 packages waiting to sync and 13 regressions .
rm-controls:master ← sloretz:sloretz__fix_failed_to_find_effort_controllers
opened 01:22AM - 20 Dec 22 UTC
This fixes a build failure on all platforms on the ROS Noetic buildfarm: https:/… /build.ros.org/job/Nbin_uF64__mimic_joint_controller__ubuntu_focal_amd64__binary/197/console
```
23:15:30 [ 50%] Building CXX object CMakeFiles/mimic_joint_controller.dir/src/mimic_joint_controller.cpp.o
23:15:30 /usr/lib/ccache/c++ -DROSCONSOLE_BACKEND_LOG4CXX -DROS_BUILD_SHARED_LIBS=1 -DROS_PACKAGE_NAME=\"mimic_joint_controller\" -Dmimic_joint_controller_EXPORTS -I/tmp/binarydeb/ros-noetic-mimic-joint-controller-0.1.7/include -I/opt/ros/noetic/include -I/opt/ros/noetic/share/xmlrpcpp/cmake/../../../include/xmlrpcpp -g -O2 -fdebug-prefix-map=/tmp/binarydeb/ros-noetic-mimic-joint-controller-0.1.7=. -fstack-protector-strong -Wformat -Werror=format-security -DNDEBUG -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -o CMakeFiles/mimic_joint_controller.dir/src/mimic_joint_controller.cpp.o -c /tmp/binarydeb/ros-noetic-mimic-joint-controller-0.1.7/src/mimic_joint_controller.cpp
23:15:30 In file included from /tmp/binarydeb/ros-noetic-mimic-joint-controller-0.1.7/src/mimic_joint_controller.cpp:5:
23:15:31 /tmp/binarydeb/ros-noetic-mimic-joint-controller-0.1.7/include/mimic_joint_controller/mimic_joint_controller.h:9:10: fatal error: effort_controllers/joint_position_controller.h: No such file or directory
23:15:31 9 | #include <effort_controllers/joint_position_controller.h>
23:15:31 | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
23:15:31 compilation terminated.
```
Likely culprit is #81 removing the dependency on `hardware_interface`. `mimic_joint_controller` includes on headers from `effort_controllers` and `hardware_interface`, so it must have dependencies on them too.
https://github.com/rm-controls/rm_controllers/blob/9c8058bfcd526c70568ef094e92256d6e22a1cec/mimic_joint_controller/include/mimic_joint_controller/mimic_joint_controller.h#L8-L9
1 Like
sloretz
December 30, 2022, 12:09am
2
. Now is a great time to make releases for the next sync 
