Rclcpp Build/CI failed with uncrustify

Recently, I found that rclcpp ci failed because of uncrustify,
which are, while I believe, not caused by the last commit
such as Rpr__rclcpp__ubuntu_noble_amd64 #38 [Jenkins]

	Test Result (failed)
projectroot.uncrustify
projectroot.uncrustify
projectroot.uncrustify
projectroot.uncrustify
rclcpp.uncrustify.include/rclcpp/any_subscription_callback.hpp
rclcpp.uncrustify.include/rclcpp/create_subscription.hpp
rclcpp.uncrustify.include/rclcpp/detail/qos_parameters.hpp
rclcpp.uncrustify.include/rclcpp/function_traits.hpp
rclcpp.uncrustify.include/rclcpp/loaned_message.hpp
rclcpp.uncrustify.include/rclcpp/macros.hpp
rclcpp.uncrustify.include/rclcpp/node_interfaces/node_interfaces.hpp
rclcpp.uncrustify.include/rclcpp/node_interfaces/node_parameters_interface.hpp
rclcpp.uncrustify.include/rclcpp/publisher_factory.hpp
rclcpp.uncrustify.include/rclcpp/qos_overriding_options.hpp
rclcpp.uncrustify.include/rclcpp/subscription_factory.hpp
rclcpp.uncrustify.include/rclcpp/type_adapter.hpp
rclcpp.uncrustify.include/rclcpp/wait_set_policies/dynamic_storage.hpp
rclcpp.uncrustify.include/rclcpp/wait_set_template.hpp
rclcpp.uncrustify.src/rclcpp/context.cpp
rclcpp.uncrustify.src/rclcpp/executor.cpp
rclcpp.uncrustify.src/rclcpp/executors/executor_entities_collection.cpp
rclcpp.uncrustify.src/rclcpp/executors/executor_notify_waitable.cpp
rclcpp.uncrustify.src/rclcpp/executors/static_single_threaded_executor.cpp
rclcpp.uncrustify.src/rclcpp/experimental/executors/events_executor/events_executor.cpp
rclcpp.uncrustify.src/rclcpp/intra_process_manager.cpp
rclcpp.uncrustify.src/rclcpp/node_interfaces/node_graph.cpp
rclcpp.uncrustify.src/rclcpp/node_interfaces/node_parameters.cpp
rclcpp.uncrustify.src/rclcpp/publisher_base.cpp
rclcpp.uncrustify.src/rclcpp/subscription_base.cpp
rclcpp.uncrustify.src/rclcpp/typesupport_helpers.cpp
rclcpp.uncrustify.test/mocking_utils/patch.hpp
rclcpp.uncrustify.test/rclcpp/allocator/test_allocator_common.cpp
rclcpp.uncrustify.test/rclcpp/allocator/test_allocator_deleter.cpp
rclcpp.uncrustify.test/rclcpp/executors/test_events_executor.cpp
rclcpp.uncrustify.test/rclcpp/executors/test_executors.cpp
rclcpp.uncrustify.test/rclcpp/executors/test_executors_intraprocess.cpp
rclcpp.uncrustify.test/rclcpp/executors/test_multi_threaded_executor.cpp
rclcpp.uncrustify.test/rclcpp/node_interfaces/test_node_interfaces.cpp
rclcpp.uncrustify.test/rclcpp/node_interfaces/test_node_parameters.cpp
rclcpp.uncrustify.test/rclcpp/strategies/test_allocator_memory_strategy.cpp
rclcpp.uncrustify.test/rclcpp/test_add_callback_groups_to_executor.cpp
rclcpp.uncrustify.test/rclcpp/test_any_service_callback.cpp
rclcpp.uncrustify.test/rclcpp/test_client_common.cpp
rclcpp.uncrustify.test/rclcpp/test_context.cpp
rclcpp.uncrustify.test/rclcpp/test_function_traits.cpp
rclcpp.uncrustify.test/rclcpp/test_generic_pubsub.cpp
rclcpp.uncrustify.test/rclcpp/test_logger.cpp
rclcpp.uncrustify.test/rclcpp/test_logging.cpp
rclcpp.uncrustify.test/rclcpp/test_node.cpp
rclcpp.uncrustify.test/rclcpp/test_parameter_client.cpp
rclcpp.uncrustify.test/rclcpp/test_parameter_event_handler.cpp
rclcpp.uncrustify.test/rclcpp/test_parameter_map.cpp
rclcpp.uncrustify.test/rclcpp/test_publisher.cpp
rclcpp.uncrustify.test/rclcpp/test_publisher_with_type_adapter.cpp
rclcpp.uncrustify.test/rclcpp/test_qos_event.cpp
rclcpp.uncrustify.test/rclcpp/test_rosout_subscription.cpp
rclcpp.uncrustify.test/rclcpp/test_service.cpp
rclcpp.uncrustify.test/rclcpp/test_service_introspection.cpp
rclcpp.uncrustify.test/rclcpp/test_subscription.cpp
rclcpp.uncrustify.test/rclcpp/test_subscription_content_filter.cpp
rclcpp.uncrustify.test/rclcpp/test_subscription_traits.cpp
rclcpp.uncrustify.test/rclcpp/test_timer.cpp
rclcpp.uncrustify.test/rclcpp/topic_statistics/test_subscription_topic_statistics.cpp
rclcpp.uncrustify.test/rclcpp/topic_statistics/test_topic_stats_utils.hpp
rclcpp.uncrustify.test/utils/rclcpp_gtest_macros.hpp
rclcpp_lifecycle.uncrustify.test/mocking_utils/patch.hpp
rclcpp_lifecycle.uncrustify.test/test_lifecycle_node.cpp
rclcpp_action.uncrustify.include/rclcpp_action/create_client.hpp
rclcpp_action.uncrustify.include/rclcpp_action/create_server.hpp
rclcpp_action.uncrustify.include/rclcpp_action/server.hpp
rclcpp_action.uncrustify.src/server.cpp
rclcpp_action.uncrustify.test/benchmark/benchmark_action_server.cpp
rclcpp_action.uncrustify.test/mocking_utils/patch.hpp
rclcpp_action.uncrustify.test/test_client.cpp
rclcpp_action.uncrustify.test/test_server.cpp
rclcpp_components.uncrustify.include/rclcpp_components/node_instance_wrapper.hpp
rclcpp_components.uncrustify.include/rclcpp_components/register_node_macro.hpp
rclcpp_components.uncrustify.test/test_component_manager_api.cpp

Could anybody tell me how to solve this problem? or we just ignore them…
Thanks

We need to do a release of ament_lint to get Adds uncrustify 0.78.1 config by marcoag · Pull Request #475 · ament/ament_lint · GitHub out into the binaries. Once that is in, these should go away.

3 Likes

Thanks a lot, this cleared up my confusion

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.