ROS Resources: Documentation | Support | Discussion Forum | Service Status | Q&A answers.ros.org

ROS Quality Assurance Working Group September 2018 Meeting Notes


#1

Dear all,

This is the month of September meeting notes.

Agenda

  1. Where are we at? A brief overview of the progress in the implementation of ROSIN QA initiatives (Adam)

  2. Update from Matt Drotter on use rating solution for “Making ROS Quality Visible”.

  3. Static Analysis (Zhoulai and Davide)

  4. Thomas present Statick

Discussion

  1. Where are we at?
    1. These are the initiatives and the corresponding update:
      1. Making ROS Quality Packages visible. Phase I, which is the CI badge has been implemented and Phase II (i.e. Quality Dashboard) is work in progress. The GUI is built, needs minor enhancements. The integration to Haros is remaining to do. https://git-afsantos.github.io/ros-wiki-qa-experiment/. We calling for help to finish the work (integrate the GUI to Haros). If you like to assist please get in touch?
      2. The user rating feature has been discussed. We looked at how we can leverage the current capabilities (i.e. Wiki) to implement this feature. It appears that it requires some effort which we are not resourced for. The group has decided to postpone the work on this to the future and focus on the quality dashboard.
      3. Appoint ownership for QA initiatives. As per previous notes, the decision is to appoint the person or the group doing the implementation as owners by default, unless they advise otherwise, In such case, we seek owners from the community.
      4. Energize the code review practice: We will run a pilot in two repository, MoveIt and rviz. We have a draft code review document, which is being reviewed by group members. Once we have a final version, we will upload it online and hopefully some code review in the pilot repositories will commence.
      5. Static analysis: ROSIN is looking to commence the scanning of some ROS packages. This work is being planned.
    2. Some of the planned future work:
      1. Address the maintenance issue,
      2. Energize the CI service,
      3. Onboarding of newcomer, etc…
  2. Statick:
    1. Thomas Denewiler presented the tool https://github.com/sscpac/statick. The group discuss the capabilities and the potentials of the tool.

Thanks
Adam


#3

Static analysis: ROSIN is looking to commence the scanning of some ROS packages. This work is being planned.

Hi, since I am not using the static analysis in my daily development and know very little of them, but I was also asked by other people about situation of static analysis of ROS system and setup coverity scan service. If I need to release this project from my dashboard, please let me know.

https://scan.coverity.com/projects/ros_comm?tab=overview

I’m also interested in the memory leak issue reported at https://github.com/ros/ros_comm/issues/1433, and if the static analysis can find this, that’s would be great. But as far as I see, they did not report that. Is it ok? or the scan service should report this as a defect?